search

jharding / grunt-exec

Grunt plugin for executing shell commands.
https://npmjs.org/package/grunt-exec
Other
248 stars 47 forks source link

Adding support for multiple allowed exit codes for option.exitCode #30

Closed joakimbeng closed 10 years ago

joakimbeng commented 11 years ago

This is a great an useful gruntplugin!

In my build process I have a 3rd party command that can both fail and succeed which is normal and a failure doesn't affect anything that should prevent the whole build from succeeding. To support this I need to be able to provide an array of allowed exit codes for the command that grunt-exec executes, which is exactly what this commit does.

The feature does not break compatibility with existing versions because exit code can still be provided as before.

I hope you like it and will accept it :)

jharding commented 10 years ago

Looks good, I'll get this into the next release. Sorry for the delay in getting back to you, I haven't been a very good maintainer over the past few months.

joakimbeng commented 10 years ago

Nice :+1: