search

jhass / insporation

Flutter based client for diaspora*
BSD 3-Clause "New" or "Revised" License
30 stars 3 forks source link

Error message details dialog #29

Closed jhass closed 3 years ago

jhass commented 3 years ago

Includes and supersedes #22

Sorry for the drive by commits :)

jhass commented 3 years ago

Some minor changes. It feels uncommon to see a warning above the textfield and the login-button. The visual flow seems to be disturbed. Can the message be between the button and a possible list of other usernames?

Bildschirmfoto 2020-11-14 um 11 26 17

I played with various positions and this one felt the least worst. Placing it between the button and the list or between the logo and the form field felt even more disturbing. You can easily play with this by moving the ErrorMessage widget to different positions within the Column widget.

By the way looking at this, I guess I forgot to populate the error details parameter on the RPC bus with a formatted full trace for the iOS side of things. Do you want to take a look at that?

tclaus commented 3 years ago

Yep. I'll take a look.