search

jhc13 / taggui

Tag manager and captioner for image datasets
GNU General Public License v3.0
495 stars 26 forks source link

Settings refactor #193

Open yggdrasil75 opened 4 weeks ago

yggdrasil75 commented 4 weeks ago

makes settings menu have tabs. probably could use side tabs instead of top tabs. depends on number of submenus, but that is down the road.

need to move some more settings to this before its confirmed. at minimum captioning device. but what else?

jhc13 commented 4 weeks ago

Is there anything else that you think should be moved to the settings? If it's just the captioning device, I don't think we have enough settings there yet to switch to tabs.

yggdrasil75 commented 4 weeks ago

show/hide probabilities, load in 4 bit, device is 2 settings: device and index. (could be 1 for the more advanced users. cuda:0/cpu/cuda:1/whatever. but less advanced use gpu vs cpu and gpu index) also a setting that disables resets of less impactful settings on crash (ie: dont reset font size if it crashes. its like a .00001% chance that is the cause) the new notify option from 180 could be a permanent option in settings I would like to change the "max tokens" via settings (instead of 75, I typically go for 225) and could also have counting method as an option (ie: estimate tokens, count words, count characters, count tags) image preprocessing method from 185 could be includeed I would also like to add a formatting method option in the future: currently its plaintext separated by a specified character. everydream trainer uses yamls where you set a main prompt, tags with optional weights (shuffle/drop weights). in addition: some trainers use .caption instead of .txt

overall, with all that is in it now, this is definitely rather barebones of a change. with the options above that may be included, this PR is a futureproofing technique. would be easier to add it now and then as new settings are added, put them in the right place than add later and try moving when there is many settings.

jhc13 commented 4 weeks ago

I think some of those should be left where they are (like "show probabilities").

Maybe you could not move any settings in this PR, and we can move and add settings separately later.

yggdrasil75 commented 4 weeks ago

oh? then I guess its ready as is (except let me move extensions to directory.)

yggdrasil75 commented 4 weeks ago

what is vsc doing to me? why does it have a merge branch when I just push a change?