v8 stable release.

[mshima]

Overview of the feature request

Track v8 blocking issues.

TODO:

• [x] Heroku sub gen update https://github.com/jhipster/generator-jhipster/pull/23971
• [x] Update to yeoman v7 https://github.com/jhipster/generator-jhipster/issues/23868
• [x] Generated maven project uses spring-boot version but incorrectly pulls wrong springframework https://github.com/jhipster/generator-jhipster/issues/23883
• [x] Increase recently added code test coverage to 80% (Optional) https://github.com/jhipster/generator-jhipster/pull/24051

Breaking changes:

• [x] https://github.com/jhipster/generator-jhipster/issues/19112
• [x] ~https://github.com/jhipster/generator-jhipster/issues/21821~

Migrate blueprints and check/implement individual requirements:

• [x] entity-audit: https://github.com/jhipster/generator-jhipster-entity-audit/pull/207
• [x] native https://github.com/jhipster/generator-jhipster-native/pull/85
• [x] ionic: https://github.com/jhipster/generator-jhipster-ionic/issues/927
• [x] micronaut: https://github.com/jhipster/generator-jhipster-micronaut/issues/288
• [ ] quarkus: https://github.com/jhipster/generator-jhipster-quarkus/issues/294
• [ ] react-native: https://github.com/jhipster/generator-jhipster-react-native/issues/1410
• [x] jooq cc @mshima https://github.com/jhipster/generator-jhipster-jooq/pull/19
• [ ] svelte cc @vishal423 https://github.com/jhipster/generator-jhipster-svelte/issues/1862
• [x] dotnet cc @nicolas63 https://github.com/jhipster/jhipster-dotnetcore/issues/1340
• [ ] kotlin cc @sendilkumarn https://github.com/jhipster/jhipster-kotlin/issues/378
• [x] nodejs cc @amanganiello90: https://github.com/jhipster/generator-jhipster-nodejs/issues/300
• [x] ~go cc @deepu105 ?~

Motivation for or Use Case

Related issues or PR

• [x] Checking this box is mandatory (this is just to show you read everything)

[deepu105]

I don't think we have to wait for all blueprints to migrate as they can migrate at their own pace

[nicolas63]

I have create the issue on the jhipter-dotnet blueprint but i need your help to migrate

[mshima]

I have create the issue on the jhipter-dotnet blueprint but i need your help to migrate

I’ve started the migration.

[mraible]

@mshima I appreciate all the work you're doing to make JHipster 8.0 happen. Please let me know if there's anything I can do to help!

[mshima]

@mraible some help updating heroku generator would be great. We should target heroku for 8.1.

With micronaut (java) and dotnetcore (2 client generators and a server) been updated. I would say we should go ahead and release a RC as soon as possible and final a week later.

I will take a look at ci-cd generator and nodejs and ionic blueprints this weekend.

I hope to have a simultaneous release for every migrated blueprint.

[deepu105]

I can do and RC release this weekend. Let me know if I should wait for any ticket to be merged

On Fri, 29 Sept 2023, 6:17 pm Marcelo Shima, @.***> wrote:

@mraible https://github.com/mraible some help updating heroku generator would be great. We should target heroku for 8.1.

With micronaut (java) and dotnetcore (2 client generators and a server) been updated. I would say we should go ahead and release a RC as soon as possible and final a week later.

I will take a look at ci-cd generator and nodejs and ionic blueprints this weekend.

I hope to have a simultaneous release for every migrated blueprint.

— Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/23449#issuecomment-1741161446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKF7LL3VWT7CSEX3EWQ3X43YDBANCNFSM6AAAAAA4QQDERM . You are receiving this because you were mentioned.Message ID: @.***>

[mshima]

@deepu105 any news about a new release?

[deepu105]

I waiting for confirmation. I can do the RC release tomorrow.

On Fri, 13 Oct 2023, 1:21 pm Marcelo Shima, @.***> wrote:

@deepu105 https://github.com/deepu105 any news about a new release?

— Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/23449#issuecomment-1761349711, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKFZJTYNITOQLQWCP5LDX7EP3NANCNFSM6AAAAAA4QQDERM . You are receiving this because you were mentioned.Message ID: @.***>

[mshima]

Please go ahead.

[deepu105]

Its underway. Should be out today if everything goes well or latest tomorrow

On Fri, 13 Oct 2023, 11:53 pm Marcelo Shima, @.***> wrote:

Please go ahead.

— Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/23449#issuecomment-1762286814, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKFY2D6HMP6KTTESUZ43X7GZ5NANCNFSM6AAAAAA4QQDERM . You are receiving this because you were mentioned.Message ID: @.***>

[deepu105]

RC released

[deepu105]

I can do the final release next weekend

[mraible]

I hope to work on the Heroku sub-generator this week and improve the Ionic blueprint to support file uploads on the web. Neither of these should hold up an RC release.

[mshima]

https://github.com/jhipster/generator-jhipster/issues/23868 should to be considered before final. We can keep yeoman-generator v6 or move to v7.

[mraible]

I created issues for the blueprints that didn't have v8 upgrade issues. These do not be updated before releasing v8.

[mraible]

We should make sure test coverage is above 80% before releasing. We're currently failing our quality gate.

[deepu105]

So I guess we have below task to complete for v8 final

• [x] Heroku sub gen update https://github.com/jhipster/generator-jhipster/pull/23971
• [x] Update to yeoman v7 https://github.com/jhipster/generator-jhipster/issues/23868
• [ ] Increase test coverage to 80%

[mraible]

@deepu105 Yes, I agree. I added links to the issues that exist. Maybe we should move these up to the description so they're not lost. @mshima Do you have any more to add?

[mshima]

I think https://github.com/jhipster/generator-jhipster/issues/23883 is a blocker. It’s probably in jhipster-bom.

The sonar quality gate is red due to coverage on new code, not overall. Not a blocking IMO.

[mraible]

I agree that Sonar can be disregarded. It'd be cool if the report was from scratch each time rather than incremental.

Does the Spring dependency issue happen with a brand-new Spring Boot project? If not, it's probably related to our BOM vs Spring Boot’s.

[mshima]

It’s probably in jhipster-bom.

[mraible]

@mshima I tried creating a new micro frontends architecture using:

jhipster jdl reactive-mf.jdl --monorepository --workspaces

It gives me a bunch of warnings. Do I need to update the reactive-mf.jdl file to add a custom id?

WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict

[mraible]

I might've fixed https://github.com/jhipster/generator-jhipster/issues/23883. If it works, can you create a release this week, @deepu105?

[mshima]

@mshima I tried creating a new micro frontends architecture using:

jhipster jdl reactive-mf.jdl --monorepository --workspaces

It gives me a bunch of warnings. Do I need to update the reactive-mf.jdl file to add a custom id?

WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict

@mraible fixed in https://github.com/jhipster/generator-jhipster/pull/24046.

[mraible]

👀 Our quality gate is looking good!

@mshima @DanielFran Do we need anything else before releasing 8.0?

[DanielFran]

@mraible I believe everything is done.

We still have this PR to remove AngularJS locale configuration but we do not have anything to replace that could manage i18n. But I do not think this is blocking the release.

And I realised that today Neo4J is broken: https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/6702088203

[DanielFran]

@mshima Is this https://github.com/jhipster/generator-jhipster/issues/24028 blocking the release?

[mshima]

@mshima Is this #24028 blocking the release?

It's a quite annoying bug, not sure how much the user is affected. Are you planning to cut the release?

[mshima]

@mshima Is this #24028 blocking the release?

This is actually jhipster v7 behavior, since we used to delegate to the local generator-jhipster.

[DanielFran]

@mshima Is this #24028 blocking the release?

It's a quite annoying bug, not sure how much the user is affected. Are you planning to cut the release?

I believe it was supposed to create the final version now, not a new RC version

[mshima]

@mshima Is this #24028 blocking the release?

It's a quite annoying bug, not sure how much the user is affected. Are you planning to cut the release?

I believe it was supposed to create the final version now, not a new RC version

Yes, there are huge changes to the core since the RC, but I think it's ok to go final. I want to know if you are planning to release in the middle of this week.

[mraible]

@mshima What's your preference? As the primary contributor to 8.0, we're happy to follow your advice.

@deepu105 Can you do a release today or tomorrow if everyone approves? It might be fun to release on Halloween! 👻🎃

[mshima]

One last PR https://github.com/jhipster/generator-jhipster/pull/24067.

[MarkingYang]

您好，我最近学业繁忙，无法亲自回复您的邮件。晚间查看后，会尽快给您回复。

[mraible]

@mshima I'm testing this blog post and when I run jhipster jdl microservices.jdl, it still has warnings:

WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict

Here's the JDL:

application {
  config {
    baseName gateway
    packageName com.okta.developer.gateway
    applicationType gateway
    authenticationType oauth2
    buildTool gradle
    clientFramework vue
    prodDatabaseType postgresql
    serviceDiscoveryType consul
    testFrameworks [cypress]
  }
  entities Blog, Post, Tag, Product
}

application {
  config {
    baseName blog
    packageName com.okta.developer.blog
    applicationType microservice
    authenticationType oauth2
    buildTool gradle
    databaseType neo4j
    enableHibernateCache false
    serverPort 8081
    serviceDiscoveryType consul
  }
  entities Blog, Post, Tag
}

application {
  config {
    baseName store
    packageName com.okta.developer.store
    applicationType microservice
    authenticationType oauth2
    buildTool gradle
    databaseType mongodb
    enableHibernateCache false
    serverPort 8082
    serviceDiscoveryType consul
  }
  entities Product
}

entity Blog {
  name String required minlength(3)
  handle String required minlength(2)
}

entity Post {
  title String required
  content TextBlob required
  date Instant required
}

entity Tag {
  name String required minlength(2)
}

entity Product {
  title String required
  price BigDecimal required min(0)
  image ImageBlob
}

relationship ManyToOne {
  Blog{user(login)} to User with builtInEntity
  Post{blog(name)} to Blog
}

relationship ManyToMany {
  Post{tag(name)} to Tag{post}
}

paginate Post, Tag with infinite-scroll
paginate Product with pagination

microservice Product with store
microservice Blog, Post, Tag with blog

deployment {
  deploymentType docker-compose
  appsFolders [gateway, blog, store]
  dockerRepositoryName "mraible"
}

The rest of the tutorial works, there's just this these warnings at the beginning.

[mshima]

@mraible some context of this warning is at https://github.com/jhipster/generator-jhipster/pull/23850

At the PR we started relying on the frontend type to do some conversions and failed due to id different types related to different databases (gateway uses postgres with Long ids, microservice uses cassandra with UUID ids).

We used to carry on databaseType at the entity level, but this is quite hackish and hard to maintain, and we are decoupling jdl from business. As alternative, we are advising the user to specify the entity's id type which looks much more reliable and cleaner than carrying databaseType around at entity level.

[deepu105]

I'll do the release sometime this week

On Wed, 1 Nov 2023, 11:03 am Marcelo Shima, @.***> wrote:

@mraible https://github.com/mraible some context of this warning is at

23850 https://github.com/jhipster/generator-jhipster/pull/23850

At the PR we started relying on the frontend type to do some conversions and failed due to id different types related to different databases (gateway uses postgres with Long ids, microservice uses cassandra with UUID ids).

We used to carry on databaseType at the entity level, but this is quite hackish and hard to maintain, and we are decoupling jdl from business. As alternative, we are advising the user to specify the entity's id type which looks much more reliable and cleaner than carrying databaseType around at entity level.

— Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/23449#issuecomment-1788700934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIOKF4D4R6EJSYNJ4C6GU3YCINANAVCNFSM6AAAAAA4QQDEROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYG4YDAOJTGQ . You are receiving this because you were mentioned.Message ID: @.***>

[mraible]

As alternative, we are advising the user to specify the entity's id type which looks much more reliable and cleaner than carrying databaseType around at entity level.

How do I change my JDL to get rid of this warning?

[mshima]

As alternative, we are advising the user to specify the entity's id type which looks much more reliable and cleaner than carrying databaseType around at entity level.

How do I change my JDL to get rid of this warning?

Neo4J and MongoDB default primary keys are String and there is no entity served in Gateway. Add id String field to every entity.

[mraible]

I can confirm that adding id String to the JDL makes the warning go away. Here's the commit with the update. Is required necessary for primary keys?

[mshima]

I can confirm that adding id String to the JDL makes the warning go away. Here's the commit with the update. Is required necessary for primary keys?

No, the id should imply required. Maybe you want to add the Id annotation @Id id String I think is prettier.

[mraible]

OK, updated in https://github.com/oktadev/okta-blog/pull/1366/commits/9f4f171f2676fedcf6bd499582a646b5ceebf41b.

In the generated Java classes, I noticed the biggest difference is removing required results in @NotNull being removed:

-    @NotNull
     @Id
     private String id;

[mshima]

@DanielFran bounty claimed https://opencollective.com/generator-jhipster/expenses/203358.

[DanielFran]

@mshima approved