Deploy to GCP - Githubissues

jhipster / jhipster-lite

JHipster Lite ⚡ is a development platform to generate, develop & deploy modern web applications & microservices architecture, step by step - using Hexagonal Architecture :gem:

https://lite.jhipster.tech

Apache License 2.0

468 stars 215 forks source link

Deploy to GCP #10383

Open pascalgrimaud opened 4 months ago

pascalgrimaud commented 4 months ago

To be consistent with JHipster Online, I'm studying to deploy to GCP after each release.

So we'll have an official version at lite.jhipster.tech which is up-to-dated and not depend on @jdubois

Cc @murdos @renanfranca

pascalgrimaud commented 4 months ago

@PierreBesson created the project in GCP, I'll be able to work on it after holidays

pascalgrimaud commented 3 months ago

Still on vacations but I managed to work on this, this morning Here the deployed app: https://jhipster-lite.ew.r.appspot.com

I'll update the cloudflare part too

I'll finish the work maybe this weekend or next week

renanfranca commented 3 months ago

Still on vacations but I managed to work on this, this morning Here the deployed app: https://jhipster-lite.ew.r.appspot.com

I'll update the cloudflare part too

I'll finish the work maybe this weekend or next week

It's really cool! Thanks!!! 👏👏👏

pascalgrimaud commented 3 months ago

The version at https://lite.jhipster.tech/ is up-to-date !

After discussion with @murdos this morning, he would like to deploy the main branch instead of a release version

So 3 solutions here:

[1] : stay like today, deploy to GCP, only at each release
[2] : deploy the main branch instead of a release version
[3] : deploy release + main branch

I think the 3 is overkilled, and will consume too much resource at GCP

About me, I don't have a strong opinion on this, as I don't use a lot the cloud version. Maybe it will change once the PR feature will be available :)

renanfranca commented 3 months ago

Congratulations 🎊 and thank you, @pascalgrimaud! That's a really cool feature!

I think I'll go for option [2] - publishing from the main branch. Here are my thoughts:

We don't need someone to approve what's in the main branch before creating a release and publishing it.
I'm planning to use JHipster Lite to create a personal project, and the first thing I thought of was generating the project from the main branch.
Since we are a state-of-the-art project, it would be great to deliver improvements as soon as possible.
I believe our main branch is stable enough for that.

pascalgrimaud commented 3 months ago

Lighter option 2, would be:

auto deploy main branch every night
possibility to manually deploy when needed the main branch

With this, after each new PRs from Renovate bot and other, there won't be new deployment... so no spam here

renanfranca commented 3 months ago

Lighter option 2, would be:

auto deploy main branch every night

possibility to manually deploy when needed the main branch

With this, after each new PRs from Renovate bot and other, there won't be new deployment... so no spam here

I prefer that one! No overhead 👌👏

murdos commented 3 months ago

With this, after each new PRs from Renovate bot and other, there won't be new deployment... so no spam here

Do you fear some extraneous GCP cost because of that "spam"? Or that the service won't be available during deployment? I'm OK with a daily deployment of main, it's just a bit sad that we don't use state of the art with continuous deployment :)

pascalgrimaud commented 3 months ago

I think specially about cost

PierreBesson commented 3 months ago

Cost shouldn't be an issue there is no extra costs associated with deployments on either AppEngine or CloudRun. I would worry more on maintenance with potentially having to troubleshoot failed deployment more frequently but as we have solid e2e tests that shouldn't be a problem.