This PR adds the necessary changes to make the PolyScope osdialog usage work within Cardinal.
Since osdialog calls are blocking, Cardinal does not use it (it is in my opinion very bad practice for plugins to block the main event loop).
Changes to the code are made in a way that compatibility with regular Rack remains intact.
Let me know if you have any questions.
Thanks for the nice modules by the way!
PS: Cardinal's message dialogs are built-in the plugin, not OS-level dialogs.
jhoar
commented
2 years ago
Hi there.
This PR adds the necessary changes to make the PolyScope
osdialogusage work within Cardinal. Sinceosdialogcalls are blocking, Cardinal does not use it (it is in my opinion very bad practice for plugins to block the main event loop).Changes to the code are made in a way that compatibility with regular Rack remains intact. Let me know if you have any questions.
Thanks for the nice modules by the way!
PS: Cardinal's message dialogs are built-in the plugin, not OS-level dialogs.