jhomlala / betterplayer

Better video player for Flutter, with multiple configuration options. Solving typical use cases!
Apache License 2.0
932 stars 1.04k forks source link

The author has not maintained this library anymore, everyone can continue to use it in the new library! #1201

Open AnonymHK opened 1 year ago

AnonymHK commented 1 year ago

I really like this component, but jhomlala no longer maintains this library and responds to community messages. I have reopened a library to handle community submitted issues, with the main purpose of fixing bugs and maintaining some components, such as the exoplayer, and facilitating community merging functions. If you have a Pull, you can submit it to a new address. I will process and update all Pulls within 48 hours! Welcome all users who like this component to participate together!

https://github.com/AnonymHK/betterplayer

IKRAMULHAQ786 commented 1 year ago

How can we use your version of library?

AnonymHK commented 1 year ago

Download directly to the local location and reference the component! For example:

betterplayer: path: ../betterplayer

IKRAMULHAQ786 commented 1 year ago

I am new to flutter so please can you tell me that do I need to put these files in the project directory?

AnonymHK commented 1 year ago

You need to modify pubspec.yaml in dependency_ Overrides: (If not, add the following content after flutter_icons:):

betterplayer: path: ../ your packages/betterplayer

AnonymHK commented 1 year ago

Yes, you need to download the plugin locally and import it!

Josebergon commented 1 year ago

Hi! Did you just fork the repository to update it in the future or did you also update/merge some of the pull requests that are already here? Thanks.

AnonymHK commented 1 year ago

You can go in and check the comments. I have merged and corrected the code submitted in Pull, and updated ExoPlayerVersion to the latest 2.18.6, as well as some other components to the latest supported version!

guyluz11 commented 1 year ago

Yes, you need to download the plugin locally and import it!

There is a more elegant way, no need to "download the plugin locally"

in pubspec.yaml under dependencies: add the package like this

  better_player:
    git: 'https://github.com/AnonymHK/betterplayer.git'
guyluz11 commented 1 year ago

Also @AnonymHK instead of creating your own why not offer to maintain this one which also exists in pub.dev and is the original Post here that you would like to take the offer https://github.com/jhomlala/betterplayer/issues/702

AnonymHK commented 1 year ago

You may not have noticed that jhomlala's account has not been active since December last year! I tried to contact him, but I didn't receive any response! So we can only rebuild a library to handle the problem!

guyluz11 commented 1 year ago

You may not have noticed that jhomlala's account has not been active since December last year! I tried to contact him, but I didn't receive any response! So we can only rebuild a library to handle the problem!

It's not a surprise that he isn't active, he opened a issue for that and prepared us for that lol. I'm quite sure that he managed to hand some permissions to another maintainer before leaving. So you're asking in the wrong place, you should post in the issue that you want it so that the other maintainers can decide.

Syed-Waleed-Shah commented 1 year ago

You may not have noticed that jhomlala's account has not been active since December last year! I tried to contact him, but I didn't receive any response! So we can only rebuild a library to handle the problem!

You should create a flutter package. Lets say you can name it better_player2. This is because everyone will be able to know that updated package exists. Secondly your commits on your github repo are in chinese or japanese... I am unable to understand things.

Eimji commented 1 year ago

Hello I have worked on this package for months. I fixed a lot of issues to make PiP worked both in Android & iOS.

So I think we should ask permission to the package author before forking the code for a new package. Or maybe the author can add new maintainers to continue the work.

The best solution is to keep this source code and add new maintainers for releasing next versions.

ash-hashtag commented 1 year ago

the author doesn't seem to be very active to talk to. We definitely want to figure out something about this package as soon as possible, this is the best video player package I've used, and I'd definitely want to see it grow in future.

And @AnonymHK try to make commit messages in english, because you know this package is being used by developers all around the world

bazmichael commented 1 year ago

@Eimji since its an open-source library, there is no need to ask for permission. Especially, when original author abandoned the package.

guyluz11 commented 1 year ago

Download directly to the local location and reference the component! For example:

Please upload the package to pub.dev

AnonymHK commented 1 year ago

直接下载到本地位置并引用该组件!例如:

请将包上传到pub.dev

I haven't figured out what name to call, so I didn't upload it to pub.dev! It is temporarily recommended to use this method:

better_player: git: 'https://github.com/AnonymHK/betterplayer.git'

guyluz11 commented 1 year ago

直接下载到本地位置并引用该组件!例如:

请将包上传到pub.dev

I haven't figured out what name to call, so I didn't upload it to pub.dev! It is temporarily recommended to use this method:

better_player: git: 'https://github.com/AnonymHK/betterplayer.git'

Just add the word plus in the end, it seems like what everyone using when uploading deprecated flutter packages.

And there is a big difference between using a package from repo with link to using it from pub.dev . The link in the repo can push updates that will not arrive to you without flutter clean for example. Or different version could be upload that brakes features without easy way to roll back and more and more. So currently I will not use your fork as for me using it like this is not stable.