jianyuan / terraform-provider-sentry

Terraform provider for Sentry
https://registry.terraform.io/providers/jianyuan/sentry/latest
MIT License
327 stars 128 forks source link

Error when handling externally-deleted organization member #446

Open ben-z opened 4 months ago

ben-z commented 4 months ago

Currently, the provider doesn't appear to handle unexpected organization member deletions well. For example:

resource "sentry_organization_member" "test_member" {
  organization = data.sentry_organization.watonomous.slug
  email        = var.email
  role         = var.org_role
}

resource "sentry_team_member" "test_team_membership" {
  organization = data.sentry_organization.watonomous.slug
  team         = var.team
  member_id    = sentry_organization_member.test_member.internal_id
}

An unexpected organization member removal would cause:

sentry_organization_member.test_member: Refreshing state... [id=watonomous/12488290]

...

2024-05-18T18:59:05.234Z [INFO]  provider.terraform-provider-sentry_v0.12.3: Removed organization membership from state because it no longer exists in Sentry: @module=sentry tf_mux_provider=tf5to6server.v5tov6Server tf_provider_addr=registry.terraform.io/jianyuan/sentry tf_rpc=ReadResource @caller=github.com/jianyuan/terraform-provider-sentry/sentry/resource_sentry_organization_member.go:105 memberID=12487829 org=watonomous tf_req_id=c2ca2d6f-826a-4d8a-30d2-f2c0c06f89d6 tf_resource_type=sentry_organization_member timestamp=2024-05-18T18:59:05.234Z

...

│ Error: Client Error
│
│   with sentry_team_member.managed_team_memberships.test_team_membership,
│   on main.tf line 220, in resource "sentry_team_member" "test_team_membership":
│  220: resource "sentry_team_member" "test_team_membership" {
│
│ unable to read organization member, got error: GET https://sentry.io/api/0/organizations/watonomous/members/12488290/: 404 The requested resource does not exist
╵

This seems to happen when a member doesn't accept their invite for an extended period of time and Sentry appears to remove the invite.

coutantal commented 3 days ago

Thanks for this one :pray: