search

jiaxinnns / pe

0 stars 0 forks source link

Edit command which doesnt actually change the NRIC does not display warning or error #11

Open jiaxinnns opened 2 weeks ago

jiaxinnns commented 2 weeks ago

image.png

Though the command appears to be changing the NRIC (in terms of the casing), it doesnt change anything since NRIC is autoformatted and show any warning and it can be misleading

![image.png] (https://raw.githubusercontent.com/jiaxinnns/pe/main/files/9bc54036-c780-4994-9a74-2592625dea66.png)

users should be warned when this happens since newer users may not realise it is autoformatted especially since the parameter table is far away from the actual command descriptions

nus-se-bot commented 1 week ago

Team's Response

Thank you for your feedback!

We chose to follow an idempotent design implementation so that our users do not need to track the change in state, but only the final state after the command. As such, we believe the current error message is fine for our intended purposes.

However, we will consider enhancing our success/error messages to be clearer and more specific in future iterations of our application.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]