search

jief666 / hdimount

Mount apple disk image (HFS, APFS, partitioned or not, compressed, encrypted) via Fuse
GNU General Public License v3.0
33 stars 2 forks source link

Interested ? #1

Open jief666 opened 6 years ago

jief666 commented 6 years ago

@tomkoen : here is my first version that integrate HFS & APFS disk images, encrypted or clear, sparsebundle or plain files. I didn't test every single possibility (APF or HSF, encrypted or clear, different compression or not, GPT or Apple map or no map make quite a lot of possibilities), but I checked quite a few. It's a work in progress branch. There is some cleaning, duplicates...

@LubosD @bugaevc : I can do some pull request if you are interested by some features (encryption, sparsebundle, etc.). Just let me know.

tomkoen commented 6 years ago

@jief666 well. I'm interested in new features but better as a part of darling-dmg, it's a mature project which I use for quite a while...

Whould be great to see new pull requests, but one by one in order to be able to test.

jief666 commented 6 years ago

Sure, I'd like that too. My point is NOT to get away from darling-dmg. I just wanted to commit something so they can see what they want (and how I did it). I made enough pull requests lately, so I thought I can temporarily commit in a new repo and give them a break. I also want to do some more cleaning, support openssl as well as embedded crypto.

I'll be more than happy if they want all, so I don't have to keep in sync. Let see what they'd like.

jief666 commented 6 years ago

I also saw that they never took your pull request about encryption, so they maybe not interested by that.

LubosD commented 6 years ago

We are interested in supporting encrypted images, but the PR felt kind of like "stealing" because it copied a lot of code from someone else's project :-D I'd also prefer using OpenSSL for crypto functions instead of having an implementation inside darling-dmg.

jief666 commented 6 years ago

I think tomkoen started from https://github.com/sgan81/apfs-fuse/blob/master/ApfsLib/DeviceDMG.cpp. I've merge something I already had and his version to make an EncryptedFileReader that support openssl. If you take it, I suppose the original author should be mentioned ? If it's ok, I'll do the pull request (without embedded crypto).

jief666 commented 6 years ago

@tomkoen , Hi, here is an updated version (in branch wip). It include Sparsebundle and encryption, APFS. In case you wonder, the goal of this project is not to fork and go his own way. In fact the HFS part is a darling-dmg submodule, and APFS is also a submodule. Compare source tree, it's barely touched.

I will continue to submit pull request to original projects, ideally to not have to fork darling-dmg or apfs-fuse for minor adjustment. But you know very well that pull requests can sometimes hang for a long time with no explanations. To speed up, I commit in this project while waiting for pull requests to be merged.

If you make a Visual C project, I'll be happy to integrate.