Why you disable IPv6 for miniupnpd?

jilir / wl500g

Automatically exported from code.google.com/p/wl500g

0 stars 0 forks source link

Why you disable IPv6 for miniupnpd? #455

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Current miniupnpd when compiled with ENABLE_IPV6 is able answer on IPv6 on 
dual-stack or IPv6-only nets ("ipv6_listening_ip" should be used for such 
case), but you don't do it for the reason unknown.

Original issue reported on code.google.com by ache...@gmail.com on 25 Oct 2014 at 1:49

GoogleCodeExporter commented 9 years ago

It requires additional libraries, libnfnetlink for example, to enable IPv6.

Original comment by lly.dev on 28 Oct 2014 at 11:11

Changed state: Done
Added labels: Type-Support
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

libnfnetlink is needed for ENABLE_NFQUEUE, not for ENABLE_IPV6. I don't notice 
other additional libs for ENABLE_IPV6, but I may miss something.

Original comment by ache...@gmail.com on 28 Oct 2014 at 10:05

GoogleCodeExporter commented 9 years ago

Just try to do it yourself - uncomment ENABLE_IPV6 and get:

linux/getroute.c:22:39: fatal error: libnfnetlink/libnfnetlink.h: No such file 
or directory

Original comment by lly.dev on 1 Nov 2014 at 2:53

GoogleCodeExporter commented 9 years ago

I can't :) I don't have Linux and bsd/getroute.c don't have such headers, it 
builds normally on BSD with ENABLE_IPV6 and without external libs.
BTW, I see linux/getroute.o is included in Makefile.linux without any 
conditions and 
#include <libnfnetlink/libnfnetlink.h>
is present in linux/getroute.c without any conditions too, so I don't 
understand how you ever compile it successfully even without ENABLE_IPV6.
(this is for miniupnpd-1.8.20140523 sources).

Original comment by ache...@gmail.com on 1 Nov 2014 at 3:08

GoogleCodeExporter commented 9 years ago

I see you specially filter out whole linux/getroute.c locally using this patch
+#include "../config.h"
+#if defined(UPNP_STRICT) || defined(ENABLE_IPV6)
+
...
+#endif /* UPNP_STRICT || ENABLE_IPV6 */
What about just removing ENABLE_IPV6 there? It is your addition, not in 
original sources.

Original comment by ache...@gmail.com on 2 Nov 2014 at 5:52

GoogleCodeExporter commented 9 years ago

Well, just do it yourself.

Original comment by lly.dev on 2 Nov 2014 at 2:43