Fixes jimsalterjrs/sanoid#851

jimsalterjrs / sanoid

These are policy-driven snapshot management and replication tools which use OpenZFS for underlying next-gen storage. (Btrfs support plans are shelved unless and until btrfs becomes reliable.)

http://www.openoid.net/products/

GNU General Public License v3.0

3.15k stars 309 forks source link

Fixes jimsalterjrs/sanoid#851 #856

Closed Pajkastare closed 10 months ago

Pajkastare commented 1 year ago

Based on text in the issue https://github.com/jimsalterjrs/sanoid/issues/851, these code changes will make sanoid skip an update of the cache file, even if it has expired, if the following logic conditions are all met:

The commands passed to sanoid include a --monitor-* command; and
No command that takes a snapshot or prunes a snapshot are supplied.

Fixes jimsalterjrs/sanoid#851

jimsalterjrs commented 10 months ago

Is this still relevant, @phreaker0 ?

phreaker0 commented 10 months ago

Is this still relevant, @phreaker0 ?

yes, but the comments needs to be addressed first.