feat: stack banners - Githubissues

mkhilai commented 3 years ago

This PR fixes the https://github.com/jina-ai/dashboard/issues/271 issue.

banners-stack

PR checklist

Docs

[ ] If you added new code; is it self documenting? (all the variable names clear, comments added where appropriate)
[ ] If you touched existing code; did you refactor existing naming, added comments where necessary?

Tests

[ ] If your ticket adds new functionality; have you added unit tests to verify behaviour?
[ ] If your ticket alters user interaction with the UI; have you added integration tests?
[ ] Do your tests check for every convievable user behabviour? (all behaviours the user can perform)

Typing

[ ] If you added new code; have you added typing?
[ ] If you touched existing code; have you improved its typing?

Styling

[ ] If new styles were created; Did you refactor/add more styles in css-in-js style?

Roshanjossey commented 3 years ago

Hi @mkhilai, thank you for making these changes. Also for adding a gif with the changes. :+1:

Could you also add some integration tests for the banners? You can see existing integration tests in cypress directory. Please reach out to us if you have any questions or if you need help :)

BastinJafari commented 3 years ago

Hi @mkhilai, I get failing tests on your PR. You can run tests with npm run test andnpm run dev + npm run cy:run

imsergiy commented 3 years ago

Great work, thanks for the contribution

jina-ai / dashboard

feat: stack banners #284

PR checklist