style(291): declare all local storage keys in a separate file - Githubissues

jina-ai / dashboard

Interactive UI for analyzing Jina logs, designing Flows and viewing Hub images

https://dashboard.jina.ai

Apache License 2.0

118 stars 60 forks source link

style(291): declare all local storage keys in a separate file #294

Closed bothmena closed 3 years ago

bothmena commented 3 years ago

PR checklist

Docs

[ ] If you added new code; is it self documenting? (all the variable names clear, comments added where appropriate)
[ ] If you touched existing code; did you refactor existing naming, added comments where necessary?

Tests

[ ] If your ticket adds new functionality; have you added unit tests to verify behaviour?
[ ] If your ticket alters user interaction with the UI; have you added integration tests?
[ ] Do your tests check for every convievable user behabviour? (all behaviours the user can perform)

Typing

[ ] If you added new code; have you added typing?
[ ] If you touched existing code; have you improved its typing?

Styling

[ ] If new styles were created; Did you refactor/add more styles in css-in-js style?

Description:

Defined local storage keys in a file (src/services/localStorageKeys.ts) as constants.
Moved local starage keys defined as constants in other files to the previously mentioned file.

closes #294

┆Issue is synchronized with this Asana task by Unito

BastinJafari commented 3 years ago

Thanks for the PR @bothmena ! Could you resolve the merge conflicts? Then I can merge it :)