Refactor/remove node sass and refactor styles - Githubissues

jina-ai / dashboard

Interactive UI for analyzing Jina logs, designing Flows and viewing Hub images

https://dashboard.jina.ai

Apache License 2.0

118 stars 60 forks source link

Refactor/remove node sass and refactor styles #337

Closed Roshanjossey closed 3 years ago

Roshanjossey commented 3 years ago

PR checklist

Please tick all of the below (if a certain item is not required for this PR please tick the box anyway)

Docs

[ ] If you added new code; is it self documenting? (all the variable names clear, comments added where appropriate)
[ ] If you touched existing code; did you refactor existing naming, added comments where necessary?

Tests

[ ] If your ticket adds new functionality; have you added unit tests to verify behaviour?
[ ] If your ticket alters user interaction with the UI; have you added integration tests?
[ ] Do your tests check for every convievable user behabviour? (all behaviours the user can perform)

Typing

[ ] If you added new code; have you added typing?
[ ] If you touched existing code; have you improved its typing?

Styling

[ ] If new styles were created; Did you refactor/add more styles in css-in-js style?
[ ] Are all fonts, sizes, colours, margins, paddings in line with designs?
[ ] Did you perform a visual comparison of the implementation with the designs?

┆Issue is synchronized with this Asana task by Unito

Roshanjossey commented 3 years ago

I've upgraded node and npm to the latest version. This results in a new lockfile (It mentions lockfileVersion 2)

Also removing react-bootstrap and shards-react and replacing it's usages with material-ui