search

jing-xiang / pe

0 stars 0 forks source link

Tampering with the data file reflects fully in program instead of error handling #6

Open jing-xiang opened 5 months ago

jing-xiang commented 5 months ago

Actual behaviour: After tampering with the data file that stores the bouquet names, the new data that I've added reflects fully in the program Expected behavior: Any error handling of choice should be used in the case of txt file tampering

Also, no practise of using separators were used in the data file, which can cause problems for data parsing

image.png

As seen below, the newline added does not have the bouquet: text

image.png

line added:new wgomwrpgmwgmr424%$@T#T#$T%#T#

nus-pe-script commented 5 months ago

Team's Response

Unclear as to what the issue is as florizzBouquets.txt stores all bouquets created during run time so that they are not lost in between uses of Florizz. The behaviour shown above is intended. Furthermore we did advise users in our userguide to not tamper with the florizzBouquets.txt file image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree that this be rejected.

As per the tP constraints, data files should be editable and manipulated by advanced users.

image_2024-04-23_12-15-38.png

Adding the line in the guide advising user not to tamper with the txt file is incorrect given the context of the tP and the PE.

Also, storing the data in command format into the txt is generally not recommended as it is not in an organised format.

Data corruption should be handled with an error message/exception.