jitsi-contrib / jitsi-helm

A helm chart to deploy Jitsi to Kubernetes
MIT License
142 stars 76 forks source link

Jigasi readiness/liveness probes do not use the health check endpoints #146

Open XenonPK opened 1 week ago

XenonPK commented 1 week ago

Hello,

When using this helm chart with jigasi support enabled, I noticed, that the container's readiness/liveness probes are simple tcp probes, instead of using the health check path provided by jigasi.

I would like to propose switching to using a http probe on port 8788, and path /about/health, at least for the liveness probes.

The advantages of this approach are:

at-platform24 commented 3 days ago

https://github.com/jitsi-contrib/jitsi-helm/blob/8f9235c5c9709dc312d47038bac2fff4d54d6765/values.yaml#L328-L333 can be updated to change the default. @XenonPK , would you like to create a PR? As of now it should obviously be possible to override these values.

Also, might be a good idea to add startup probe.