jitsi / docker-jitsi-meet

Jitsi Meet on Docker
https://hub.docker.com/u/jitsi/
Apache License 2.0
3.09k stars 1.37k forks source link

Make jigasi completely optional #48

Closed sapkra closed 5 years ago

sapkra commented 5 years ago

I noticed that when I want to setup a cluster without jigasi some jigasi specific code will be executed.

For example:

prosodyctl --config $PROSODY_CFG register $JIGASI_XMPP_USER $XMPP_AUTH_DOMAIN $JIGASI_XMPP_PASSWORD

All JIGASI_* variables should be optional. To achieve this we should implement an environment variable like JIGASI_ENABLE.

Edit: Or maybe the following is also good enough.

if [[ ! -z $JIGASI_XMPP_USER ]] && [[ ! -z $JIGASI_XMPP_PASSWORD ]]; then
    prosodyctl --config $PROSODY_CFG register $JIGASI_XMPP_USER $XMPP_AUTH_DOMAIN $JIGASI_XMPP_PASSWORD
fi
saghul commented 5 years ago

Sounds good.

saghul commented 5 years ago

49 landed, closing.