Jigasi quits the conference when user with owner permissions leaves the room

paweldomas commented 9 years ago

Jigasi quits the conference when user with owner permissions leaves the room. We should reconsider this behaviour and make it leave only when call initiator leaves or Jicofo's user leaves(or remove this logic completely).

cyrilconstantin commented 9 years ago

Indeed I have been able to reproduce it, it would be great if we can leave them in the conference within disconnecting all people who joined by jigasi!

marbis-leo commented 8 years ago

Very annoying bug/feature. Everyone here logs in as admin, SIP call is dropped all the time.

marbis-leo commented 8 years ago

This is where it happens: https://github.com/jitsi/jigasi/blob/2fc11848569e40373c2500c98a726f049ec36646/src/main/java/org/jitsi/jigasi/JvbConference.java#L735

This logic should probably be limited to the focus user, since there are plenty of valid use cases where an owner user establishes a SIP call, but leaves afterwards for whatever reason.

paweldomas commented 8 years ago

Yes, that's where it happens. Jigasi is not currently our priority, but a PR which fixes the issue would be welcome.

paweldomas commented 8 years ago

Actually this might be a one line fix, but would have to think about it and check some of Jicofo code.

marbis-leo commented 8 years ago

It's indeed a one line fix, I removed the owner user condition and it works as expected. Should I make a PR which makes it configurable? Or remove it altogether?

Reasoning:

The check does not take into account conferences with multiple owners. Some of our users have spotty network coverage and have to reconnect periodically, kicking all Jigasi participants from the conference (which annoys everyone and makes it unusable until the guilty user logs out and connects as guest).
The owner has the option of manually disconnecting the call before leaving. Owner permissions are required for making new SIP calls, so the remaining non-owner participants can't do anything dangerous even if the call stays connected. Am I missing something?
We have use cases where we'd invite a guest, call a SIP participant and then leave them alone in the room (vendor calls, etc.)

Jigasi is extremely useful for us, by the way. Apart from this, it works just fine. Thanks!

jitsi / jigasi

Jigasi quits the conference when user with owner permissions leaves the room #13