search

jitsi / jitsi-lgpl-dependencies

Submodule of libjitsi that encapsulates references to external LGPL licensed libraries.
GNU Lesser General Public License v2.1
6 stars 21 forks source link

FFmpeg 5.x #28

Open traud opened 1 year ago

traud commented 1 year ago

This Java Native Interface (JNI) is compatible with FFmpeg 4.x and older. However, starting with FFmpeg 5.x several symbols moved. This affects Ubuntu 22.10 (kinetic) and Ubuntu 23.04 (lunar) already, because those ship with FFmpeg 5.1 (riemann). I started to work on a Pull Request. Perhaps, I find the time to finish it. However on question already: For many affected symbols, I did not find any usage in LibJitsi or Jitsi Desktop. May I simply remove those?

Steps to Reproduce for Ubuntu 22.10 or newer

cd ~/Downloads
sudo apt install --no-install-recommends default-jdk build-essential pkg-config cmake maven libavcodec-extra libavfilter-dev libmp3lame-dev
wget github.com/jitsi/jitsi-lgpl-dependencies/archive/master.tar.gz
tar -xf *master.tar.gz
cd ./jitsi-lgpl-dependencies-master/
mvn compile
mkdir build
cd ./build/
cmake ../
make
ibauersachs commented 1 year ago

Thanks for the help! I knew stuff was going to break, but some of the changes were too large last time I looked at them, given all the other issues with the crashing video etc. Yes, you can most likely remove unused methods. However, please also check against jigasi: it still uses libjitsi, jitsi-lgpl-dependencies, and a bunch of libraries from Jitsi Desktop.

traud commented 1 year ago

Thanks. I will look at jigasi (and that video crashing in Java 11 LTS and 17 LTS) as well. By the way, was there a specific reason to move over to Java 11 LTS? Trying to install default-jre in Debian/Ubuntu is OK. However, I would have compiled Jitsi Desktop with Java 8 because that receives security updates even longer than Java 17 LTS.