search

jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
22.95k stars 6.69k forks source link

Cached displayName disappears on prejoin-page #8493

Closed scheibling closed 3 years ago

scheibling commented 3 years ago

Description:

When I open a meeting either via the iFrame API or directly the cached or provided via JWT displayname shows up in the box at the bottom, only to disappear moments later.

Steps to reproduce:

Edit: Apparently vanilla Jitsi Meet doesn't throw this error on its own, but after the token authentication plugin is installed.

  1. Open meeting via link
  2. Get to pre-join page, cached display name appears for a split second
  3. Cached display name disappears

Expected behavior:

Cached display name or JWT provided displayname should stay in the box and be used as default

Actual behavior:

Displayname disappears from box

Server information:

Client information:

Additional information:

Bug appeared after version update yesterday:

Upgrade: jitsi-meet-turnserver:amd64 (1.0.4466-1, 1.0.4628-1), jitsi-videobridge2:amd64 (2.1-376-g9f12bfe2-1, 2.1-416-g2f43d1b4-1), jicofo:amd64 (1.0-644-1, 1.0-692-hf-1), jitsi-meet-web:amd64 (1.0.4466-1, 1.0.4628-1), jitsi-meet:amd64 (2.0.5142-1, 2.0.5390-3), jitsi-meet-web-config:amd64 (1.0.4466-1, 1.0.4628-1), jitsi-meet-tokens:amd64 (1.0.4466-1, 1.0.4628-1), jitsi-meet-prosody:amd64 (1.0.4466-1, 1.0.4628-1)

damencho commented 3 years ago

Do you reproduce this with the latest version?

scheibling commented 3 years ago

@damencho Those were the latest compiled packages available for Debian in the repository, I'll setup a test instance with the latest version later today

scheibling commented 3 years ago

I've installed Jitsi Meet on a new server, the caching works fine when freshly installed.
What seems to break it is when I install the token authentication plugin and use a JWT to connect to the meeting

I haven't set any user details in my current setup with JWT, I'm gonna run a few tests and see if that makes any difference.

Edit: Token Authentication, not Token Moderation

scheibling commented 3 years ago

Right, so it seems that when I set the context:user:name option in the JWT with a name, this is what appears in the box.

If I leave the option unset, it'll clear the cached name as well.

I'm not sure if this is intended behaviour, if it is I can close this. I can work around the issue on my end where I generate my JWTs.

Edit: The JWT provided name also overrides the name from the userInfo-object provided in the options part when calling the iFrame API. If the JWT name is not set, the userInfo-provided name will flash shortly and then be replaced by an empty box.

saghul commented 3 years ago

In general the JWT will override all other sources for the display name.

scheibling commented 3 years ago

In general the JWT will override all other sources for the display name.

Should this be the case even when there is no display name set in JWT, the displayname being overridden by a null value? I'm guessing that's where the, in my case, unintended behaviour comes from

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.