search

jitsi / lib-jitsi-meet

A low-level JS video API that allows adding a completely custom video experience to web apps.
Apache License 2.0
1.34k stars 1.11k forks source link

Fix URL.search is not implemented for react native. #2532

Closed Romick2005 closed 5 months ago

Romick2005 commented 6 months ago

Investigating a code it seems like we do not heavily use any URL instance. In reality all that code need to do is just to work with url search string and modify it if necessary. Unfortunately react native does not support URL.search, but the lib-jitsi-meet library code use it only in one place by creating new instance of URL class, so I guess it is better to not convert string into url and then get url.search, but rather work at lower code level with strings. This would help library to have wider support (no need for URL.search polyfill), avoid URL dependency, have clear logic how restoring url is build on.

This is microimprovement, but I hope this will help the lib and have better RN support.

image

jitsi-jenkins commented 6 months ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

saghul commented 6 months ago

There are many things RN doesn't provide out of the box, the most important one being WebRTC itself. In order to keep the library small, we chose to not bnake those in here but to rather rely on the host application providing an appropriate environment.

Here is a sample of everything we are currently polyfilling: https://github.com/jitsi/jitsi-meet/tree/master/react/features/mobile/polyfills

Since there is no change we are bringing all of that in, I don't think this PR improves the status quo in a meningful enough way.

Hope you understand.