jitsi / luajwtjitsi

JWT tokens for Lua
MIT License
18 stars 10 forks source link

Remove insecure functionality #3

Closed ghost closed 3 years ago

ghost commented 3 years ago

This PR removes insecure functionality of the library in relation to this recent jitsi-meet security advisory. The change essentially removes the decode functionality of the library, making it harder to release unverified plaintext accidentally. The main changes are:

sawall commented 3 years ago

@philip-cc Looks fantastic to me. Thanks especially for the docs and new cases!

@saghul I made a PR to pin luajwtjitsi to v2 in the jitsi-meet debian build scripts so nothing wonky goes on with out builds until we get the jitsi-meet PR in: https://github.com/jitsi/jitsi-meet/pull/10262 So please approve/merge that before merging this one.

ghost commented 3 years ago

@saghul what's the status on getting this merged?

saghul commented 3 years ago

@sawall can you also take a look please?

sawall commented 3 years ago

@saghul oops, thought you were going to handle that.

saghul commented 3 years ago

Yeah sorry about that, I've been swamped lately.