Closed ghost closed 3 years ago
@philip-cc Looks fantastic to me. Thanks especially for the docs and new cases!
@saghul I made a PR to pin luajwtjitsi to v2 in the jitsi-meet debian build scripts so nothing wonky goes on with out builds until we get the jitsi-meet PR in: https://github.com/jitsi/jitsi-meet/pull/10262 So please approve/merge that before merging this one.
@saghul what's the status on getting this merged?
@sawall can you also take a look please?
@saghul oops, thought you were going to handle that.
Yeah sorry about that, I've been swamped lately.
This PR removes insecure functionality of the library in relation to this recent jitsi-meet security advisory. The change essentially removes the
decode
functionality of the library, making it harder to release unverified plaintext accidentally. The main changes are:decode
function.cjson.safe
instead of plaincjson
to safeguard against parsing vulnerabilities.basexx
instead of manual bas64 to base64url conversion.jitsi-meet
side.