jjhelmus / nmrglue

A module for working with NMR data in Python
BSD 3-Clause "New" or "Revised" License
208 stars 84 forks source link

Fix JCAMP-DX block reading #191

Closed JLVarjo closed 1 year ago

JLVarjo commented 1 year ago

The JCAMP-DX parser was a bit flawed what comes to the JCAMP "block" structuring i.e. separating data sections (of different ##DATATYPEs). The blocks should always start at ##TITLE tag (this was not respected), end to ##END tag and they may also be nested (also did not work). This PR fixes the block reading as it is specified.

Some additional notes:

kaustubhmote commented 1 year ago

Thanks, this looks good. I am merging this in now. Apologies for the delay.