Closed rserial closed 5 months ago
Strange. I'll provisionally mark this as a bug, although it should have been fixed by #196. I will take a look at this as soon as possible. Just for confirmation, you are using nmrglue version 0.10 that was released a few weeks ago right?
Hi! thanks for replying, I am using version 0.10, but now i see that issue #197 was included in the release instead of #196 which has the modication needed for the slices in line 370 (i think).
Problem: When using
ng.peakpick.pick
with the algorithms "thres" and "thres-fast" and the Numpy version ^1.22, the following error occurs:It appears to be related to the function call
find_all_thres_fast(data, pthres, msep, True)
since it returns a list forseg_slice
.Potential Fix: Modifying line 370 in peakpick.py to:
or adjusting the return of the find_all_thres_fast function accordingly.
Somehow this is not needed for numpy versions below 1.22 but for above versions it becomes a problem.