search

jk-gan / flipper-plugin-redux-debugger

Flipper plugin for Redux in React Native
MIT License
117 stars 20 forks source link

Action/state windows dock to bottom and are non-scrollable #28

Closed sweatherall closed 3 years ago

sweatherall commented 3 years ago

Flipper version: 0.63.0 RN version: 0.63.3

When focusing on a redux action, the expandable action/state windows get docked to the bottom and are not scrollable. This is inconsistent, as sometimes it will dock to the right side, but I have a very hard time figuring out what determines that to happen.

Expected behavior: These windows dock to the right side and are scrollable.

Example image of undesired behavior (action/state window docked at bottom - collapsed state)

Screen Shot 2020-11-03 at 10 16 59 AM

Please let me know what other info I can provide for you, or what I can do on my end to resolve this issue. Thank you!

mweststrate commented 3 years ago

I think you hit a temporarily layout bug in flipper 0.63 that was fixed earlier, upgrading to 0.64 should fix the problem.

On Tue, Nov 3, 2020 at 3:23 PM S. Weatherall notifications@github.com wrote:

Flipper version: 0.63.0 RN version: 0.63.3

When focusing on a redux action, the expandable action/state windows get docked to the bottom and are not scrollable. This is inconsistent, as sometimes it will dock to the right side, but I have a very hard time figuring out what determines that to happen.

Expected behavior: These windows dock to the right side and are scrollable.

Example image of undesired behavior (action/state window docked at bottom

Please let me know what other info I can provide for you, or what I can do on my end to resolve this issue. Thank you!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jk-gan/flipper-plugin-redux-debugger/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4NBEHE2ZWQY2BW4L7C5TSOAN67ANCNFSM4TI4FY6A .

sweatherall commented 3 years ago

@mweststrate looks like 0.63.0 is the latest public version of Flipper for Mac - or am I not seeing it?

I did need to upgrade react-native-flipper (0.61 --> 0.64) and redux-flipper (1.4.0 --> 1.4.2), but that did not seem to resolve the layout issue.

mweststrate commented 3 years ago

https://github.com/facebook/flipper/releases/tag/v0.64.0

On Tue, Nov 3, 2020 at 6:08 PM S. Weatherall notifications@github.com wrote:

@mweststrate https://github.com/mweststrate looks like 0.63.0 is the latest public version of Flipper for Mac - or am I not seeing it?

I did need to upgrade react-native-flipper (0.61 --> 0.64) and redux-flipper (1.4.0 --> 1.4.2), but that did not seem to resolve the layout issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jk-gan/flipper-plugin-redux-debugger/issues/28#issuecomment-721292353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4NBBCNMW663ORVY2U3YLSOBBLNANCNFSM4TI4FY6A .

sweatherall commented 3 years ago

@mweststrate thank you! Just upgraded to 0.64 and it does seem to resolve this issue. Really appreciate your help