search

jklingsporn / vertx-jooq

A jOOQ-CodeGenerator to create vertx-ified DAOs and POJOs.
MIT License
382 stars 53 forks source link

Configuration option withPostgresReactiveDriver() seems to be incorrect name #219

Open apatrida opened 1 year ago

apatrida commented 1 year ago

The configuration option withPostgresReactiveDriver as used in the quarkus demo is odd because it references io.vertx.mysqlclient as well as io.vertx.pgclient and in the demo is using a MySQL connection.

Is this really withReactiveDriver instead of PostgreSQL specific setting? If so, it should be renamed.

jklingsporn commented 1 year ago

The first reactive driver was indeed just written for Postgres-database. The adoption of other vendors happened afterwards. So yes, you are right, the name is no longer fitting.