jkoudys
commented
10 years ago Commit 52c3991 pushed. This adds several new features to the form helper:
- I'm using a 'context' now, which is a way to set data that's available to all the element's children. This is a good spot to put calls to Loader::helper(), to instantiate a helper once and make it available to all children. The form helper has a couple variables for keeping track of the IDs if you have multiple inputs of the same name, e.g. multiple select boxes named 'date' would get ID'd as 'date1', 'date2', etc. I've implemented this by putting $selectIndex as a class-variable in c5:form, then setting the :c5:form object itself as a context to be referenced later. I feel like there must be a cleaner way to do this, so I'll want to keep digging. The end result is that you can now set:
<c5:form>
<c5:form-select name="favouriteFruit[]" options={ Map { 'p' => 'Pears', 'a' => 'Apples', 'o' => 'Oranges' } } selected="a" />
<c5:form-select name="favouriteFruit[]" options={ Map { 'c' => 'Cantaloupe', 'p' => 'Pineapple', 's' => 'Strawberry' } } selected="s" />
</c5:form>and it will now render their IDs as favouriteFruit1, favouriteFruit2. This is necessary as it's what the c5 backend expects.
- form elements now all extend the :c5:base, using the 'compose, don't extend' approach recommended on Code Before the Horse.
- form elements each define the attribute of the form element it's a helper for (e.g. :c5:form-select allows any attribute a
- The :c5:form-select is now completely implemented as :xhp, with no raw HTML wrapped at any point. I still have a bit of testing + cleaning up to make sure the logic to choose which option is 'selected' works, ie re-implement this behemoth:
if ((string)$valueOrArray === (string)$k && !isset($_REQUEST[$_key]) || ($val !== false && $val == $k) || (is_array($_REQUEST[$_key]) && (in_array($k, $_REQUEST[$_key])))) {
I'm sort of torn on this decision, since I can see advantages to either side. So long as c5 helpers, like the form helper, are being maintained, it makes sense to use them in the interest of DRYness. On the other side, I wan to reduce the usage of that c5:raw element down to a minimum, and that won't happen as long as I'm just dumping out raw HTML from everything.
As the form helper is rendering actual HTML elements, that logic could be re-implemented inside the render() code for the :c5 elements themselves. This could be extra handy if traversing your xhp dom later on, since form elements are one of the main things you'd want to search inside your tree for.