search

jkwill87 / mnamer

media file renaming and organizing tool
https://pypi.org/project/mnamer
MIT License
805 stars 68 forks source link

embed application key for tmdb #200

Closed ssbarnea closed 1 year ago

ssbarnea commented 1 year ago

TMDB does also provide application level keys, which are aimed to be used by application developers to embed in their apps. This means that mnamer could include such a key to allow use without requiring each user to register a way.

I wrote this because I obtained such a key by simple filing a form, the next day I got the key for mnamer. Isn't that cool?

I would not remove the ability to define a user key, as an app key might be revoked, but from from the UX point of view, that is a great improvement. Details on https://developers.themoviedb.org/3/getting-started/introduction

jkwill87 commented 1 year ago

mnamer does indeed embed a TMDb API key. You may hit rate limiting using this default key, if so, as you've mentioned, you can specify your own via the api_key_tmdb configuration file option.

jkwill87 commented 1 year ago

Please let me know if I've missed something or misunderstood your suggestion-- will be happy to reopen and follow-up!

ssbarnea commented 1 year ago

I think tha tthe while idea of having an app key, is that this would have different rate limits, likely per IP only.