jldupont / mediawiki

Automatically exported from code.google.com/p/mediawiki
0 stars 0 forks source link

Imagelink ignores anything after a # character in links #22

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Created the imagelink:
{{#img: image=Home.png| page=Homepage#Help| content=Return to Help}}

What is the expected output? What do you see instead?
Clicking on the link takes you to Homepage not Homepage#Help The #Help is
dropped from the link.

What version of the product are you using? On what operating system?
1.60.

Please provide any additional information below.
"This is a result of a limitation in my extension in the way I build the
title object. Please add this issue to the project (i.e. googlecode).
Thanks. Jean-Lou Dupont"

Original issue reported on code.google.com by mitchell...@gmail.com on 2 Jul 2008 at 11:30

GoogleCodeExporter commented 9 years ago
Fixed in version 1.7 but requires some testing.

Original comment by JeanLou....@gmail.com on 5 Jul 2008 at 12:59

GoogleCodeExporter commented 9 years ago
Fantastic Jean-Lou. I will test this for you. Thanks!

Original comment by mitchell...@gmail.com on 14 Jul 2008 at 9:17

GoogleCodeExporter commented 9 years ago
Oh, one thing. Perhaps the same fix could be applied to pagetrail? No worries 
if not
though :-)

Original comment by mitchell...@gmail.com on 14 Jul 2008 at 9:18

GoogleCodeExporter commented 9 years ago
Okay, I've tried it with:
{{#img: image=Home_small.png| page=Requirement_Homepage#Active_REQs|title=Back 
to
Active Requirement List}}

Imagelink parses it correctly, but the link does not take you to the desired 
headertab.

I then realised it looks like there is a subtle difference required if the link 
is a
full server link like Imagelink creates. The headertab guy has confirmed this. 
You
need #tab=link e.g:
{{#img: image=Home_small.png| 
page=Requirement_Homepage#tab=Active_REQs|title=Back to
Active Requirement List}}

Imagelink does not parse the = character. You get the link:
http://l063193/mediawiki/index.php/ADP_Homepage#tab
instead of:
http://l063193/mediawiki/index.php/ADP_Homepage#tab=Active_REQs

I'm sorry about this Jean-Lou. Do not spend the time on this is it is a pain.

Original comment by mitchell...@gmail.com on 14 Jul 2008 at 9:32

GoogleCodeExporter commented 9 years ago
1) I tried the original ImageLink (i.e. 1.6.0) and it works on my wiki with the
#section. I was wondering if you could point me to your test page to have a 
look.

2) As for the '=', this is causing me some issue ... would there be a convenient
'escape char' that would be acceptable?

Original comment by JeanLou....@gmail.com on 14 Jul 2008 at 11:05

GoogleCodeExporter commented 9 years ago

Original comment by JeanLou....@gmail.com on 13 Oct 2008 at 11:43