search

jlegewie / zotfile

Zotero plugin to manage your attachments: automatically rename, move, and attach PDFs (or other files) to Zotero items, sync PDFs from your Zotero library to your (mobile) PDF reader (e.g. an iPad, Android tablet, etc.), and extract PDF annotations.
4.06k stars 282 forks source link

fixed `abbreviateField` for case when value is empty string #613

Closed vancleve closed 2 years ago

vancleve commented 2 years ago

@jlegewie: simple fix for the abbreviateField function that I added a little while ago.

vancleve commented 2 years ago

Sorry to bump this @jlegewie, its just a quick fix to the the abbreviateField we added awhile back.

jlegewie commented 2 years ago

Done. Will push a new version over the next days with a couple of fixes from pull requests.

Generally, my challenge with the PRs is that testing the change takes by far the most time. Mentioning the amount of testing and behavior with different input would help in these circumstances. This PR, for example, is simple but I don't know without testing and research when the function returns "" and whether that makes the most sense.

vancleve commented 2 years ago

right, got it! I'll put more detail in next time!