search

jlfwong / speedscope

🔬 A fast, interactive web-based viewer for performance profiles.
https://www.speedscope.app
MIT License
5.59k stars 246 forks source link

Update package.json to use upstream version of uint8array-json-parser #408

Closed jlfwong closed 2 years ago

jlfwong commented 2 years ago

In #385, I introduced a dependency on the uint8array-json-parser npm package, but used a fork because of a typescript error. This was resolved in evanw/uint8array-json-parser#1 and published as part of uint8array-json-parser@0.0.2. Let's use the upstream.

This also conveniently fixes a new typechecking error that was preventing deployment. The error looked like this:

src/import/utils.ts(2,26): error TS2306: File '\''/Users/jlfwong/code/speedscope/node_modules/uint8array-json-parser/uint8array-json-parser.ts'\'' is not a module.'

After updating to the upstream, the problem is fixed.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 41.844% when pulling 67a983f926fdfe810d8248c85ffba8a7ac6dfc25 on jlfwong/update-uint8array-json-parser-to-upstream into 1bce80693323aa93c03ba029ffee664eafd8aeaf on main.