search

jliszka / probability-monad

Apache License 2.0
263 stars 38 forks source link

Remove .par for `ev` #23

Closed fdietze closed 2 years ago

fdietze commented 2 years ago

.par doesn't work with ScalaJS

fdietze commented 2 years ago

Ah that was not trivial...

jliszka commented 2 years ago

thanks!

fdietze commented 2 years ago

Please revert, this didn't even build 😅

I'll have another look soon.

jliszka commented 2 years ago

oops!

jliszka commented 2 years ago

looks like an easy fix to replace aggregate with foldLeft

fdietze commented 2 years ago

Yes. I even thought about doing a while loop for performance reasons.

jliszka commented 2 years ago

Not a bad idea!

On Fri, Mar 18, 2022 at 11:37 AM Felix Dietze @.***> wrote:

Yes. I even thought about doing a while loop for performance reasons.

— Reply to this email directly, view it on GitHub https://github.com/jliszka/probability-monad/pull/23#issuecomment-1072529297, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYPPNOCQTNVZNCYOOOFQDVASPNHANCNFSM5RB6TVQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you modified the open/close state.Message ID: @.***>