fixed some astropy stats issues

[followthesheep]

It looks like calib.py was not importing astropy stats. Also astropy stats does not support the maxiters keyword in the version of astropy (2.0) that works with pyraf and astroconda?

[jluastro]

Ha! We were just fixing this. Let me make sure I pushed back up the change.

Maxiters is not supported in the old astropy version.

On Jun 9, 2020, at 6:12 PM, Tuan Do notifications@github.com wrote:

 It looks like calib.py was not importing astropy stats. Also astropy stats does not support the maxiters keyword in the version of astropy (2.0) that works with pyraf and astroconda?

You can view, comment on, or merge this pull request online at:

https://github.com/jluastro/nirc2/pull/15

Commit Summary

fixed some astropy stats issues File Changes

M nirc2/reduce/calib.py (16) Patch Links:

https://github.com/jluastro/nirc2/pull/15.patch https://github.com/jluastro/nirc2/pull/15.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[followthesheep]

There's also a bug in the instrument code. The CENWAVE keyword does not exist for OSIRIS.

On Tue, Jun 9, 2020, 7:40 PM Jessica Lu notifications@github.com wrote:

Ha! We were just fixing this. Let me make sure I pushed back up the change.

Maxiters is not supported in the old astropy version.

On Jun 9, 2020, at 6:12 PM, Tuan Do notifications@github.com wrote:

 It looks like calib.py was not importing astropy stats. Also astropy stats does not support the maxiters keyword in the version of astropy (2.0) that works with pyraf and astroconda?

You can view, comment on, or merge this pull request online at:

https://github.com/jluastro/nirc2/pull/15

Commit Summary

fixed some astropy stats issues File Changes

M nirc2/reduce/calib.py (16) Patch Links:

https://github.com/jluastro/nirc2/pull/15.patch https://github.com/jluastro/nirc2/pull/15.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jluastro/nirc2/pull/15#issuecomment-641685203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY56PYJMRLMK7GNTUCYBO3RV3XDPANCNFSM4NZ5FIDQ .

[followthesheep]

• bug in calling dar and distortion correction which did not pass the correct instruement keyword
• the CENWAVE keyword does not exist in osiris headers
• filter names have the aperture attached. Need to parse
• strehl calculator has issues
• combo images have problems with the submaps - the names of the masks are too long. Needed to use the same trick as in the main combo map to have shorter names. Very tricky to implement this and still work with pyfits -- probably need some sort of translator in the future.

[jluastro]

I'll note that we tested thoroughly last summer only through the clean step (to derive distortion solutions). So I think combo might still have other issues too. We need to confirm that all the DAR keywords are correct (most importantly the angles).

[followthesheep]

Sorry, didn't realize my previous pull request never got merged. This commit is not ready for a pull request