jlumbroso
commented
1 year ago Thank you so much @rake5k!
I hope you won't mind me asking you a few questions:
- Do you think this should be an option? Maybe a
allow-apt-mirrorsthat defaults totruebut can be set tofalseif needed for some reason? - @kfir4444 submit PR #8 also under consideration, which makes the point that these statements can cause the action to terminate when they fail.
- What happens if the installation of the package,
sudo gem install apt-spy2, fails? - Can this line fail too?
sudo apt-spy2 fix --commit --launchpad --country=US
- What happens if the installation of the package,
- In the line
sudo apt-spy2 fix --commit --launchpad --country=US, I notice that you hardcode the country. Presumably this would force the wrong mirrors to be picked for a user in say, East Asia. Maybe instead of using an optionallow-apt-mirrors, there should be aapt-mirror-countrythat defaults toUS, that can be changed to other countries — and when it is empty, theapt-spy2feature is not turned on?
Thanks so much for your contribution!
rake5k
This should fix #4.
Since this issue hits me in about every month's time, I ran a quick research on the root cause (e.g. https://github.com/actions/runner-images/issues/7048).
The downside of this solution is clearly that we rely on an extra package (
apt-spy2). That installation and the repository update take a few additional seconds to complete. But in my very personal case, the gained resiliency is definitely worth it.Log excerpt of an example run:
I hope, this helps others too.