jmathai / elodie

An EXIF-based photo assistant, organizer and workflow automation tool.
https://bit.ly/introducing-elodie
Apache License 2.0
1.27k stars 139 forks source link

Read-only source fails on exiftool trying to create a file in source directory #37

Open ibizaman opened 8 years ago

ibizaman commented 8 years ago

When importing from a read-only source, I get the following error:

$ ./elodie.py import --source=~/Pictures/source --destination=~/Pictures/organized --album-from-folder
/usr/local/bin/exiftool -config "./elodie/configs/ExifTool_config" -xmp-elodie:Album="2015-08 MyEvent" "~/Pictures/source/2015/2015-08 MyEvent/P8242306.JPG"
Error: Error creating file: ~/Pictures/source/2015/2015-08 MyEvent/P8242306.JPG_exiftool_tmp - ~/Pictures/source/2015/2015-08 MyEvent/P8242306.JPG

And nothing is imported in the destination folder.

jmathai commented 8 years ago

The source files should never be modified. It looks like that is not the case when using --album-from-folder.

We call set_album on the source file but I need to see about calling that after the photo has already been copied to the destination folder.

Thanks for reporting this. It's a valid issue.

ibizaman commented 8 years ago

I must say I didn't even think about removing the --album-from-folder argument.

jmathai commented 8 years ago

@ibizaman that should fix your problem but I'm leaving this open because --album-from-folder shouldn't behave this way.

ibizaman commented 8 years ago

@jmathai yes of course