jmcarp / robobrowser

BSD 3-Clause "New" or "Revised" License
3.7k stars 337 forks source link

RoboBrowser is broken with werkzeug upgrade #93

Open TijanaJakovljevic opened 4 years ago

TijanaJakovljevic commented 4 years ago

werkzeug is upgraded to 1.0.0 and RoboBrowser is broken with this change.

Traceback (most recent call last):
     from robobrowser import RoboBrowser
   File "/home/ubuntu/venv/lib/python3.7/site-packages/robobrowser/__init__.py", line 3, in <module>
     from .browser import RoboBrowser
   File "/home/ubuntu/venv/lib/python3.7/site-packages/robobrowser/browser.py", line 8, in <module>
     from werkzeug import cached_property
 ImportError: cannot import name 'cached_property' from 'werkzeug' (/home/ubuntu/venv/lib/python3.7/site-packages/werkzeug/__init__.py)

It’s because cached_property has to be explicitly imported from werkzeug.utils now 'from werkzeug.utils import cached_property' should be used instead 'from werkzeug import cached_property'

H3wastooshort commented 4 years ago

made it a prq @ #97

manishmaharjan commented 4 years ago

I had a similar issue.

import werkzeug werkzeug.cached_property = werkzeug.utils.cached_property

adding this before import robobrowsersolved the issue for me

lovetoburnswhen commented 4 years ago

I had a similar issue.

import werkzeug werkzeug.cached_property = werkzeug.utils.cached_property

adding this before import robobrowsersolved the issue for me

Worked for me as well thanks

Swastik1620 commented 2 years ago

ModuleNotFoundError: No module named 'pandas.util'