search

jminardi / mecode

GCode for all
MIT License
221 stars 61 forks source link

Use typical OS-specific serial settings by default #40

Closed sean-v8 closed 7 years ago

sean-v8 commented 8 years ago

Still somewhat hard-coded but this simplifies instantiation a bit, at least for the (very few) applications I've seen so far..

jminardi commented 7 years ago

I'd rather not merge this as it complicated the code. The user should always explicitly request the port they want to open.

sean-v8 commented 7 years ago

Oh wow this is old, yeah the point here was to add a default option for the most common Unix case since there was already one hard-coded for Windows, doesn't affect functionality at all... not a big deal, though if that's really what you want then may want to change COM5 to None and throw an exception if the port's not provided explicitly.