search

jmini / Eclipse-Copyright-Generator

Fork of http://sourceforge.net/projects/eclipsecopyrigh/
Eclipse Public License 1.0
7 stars 12 forks source link

Line endings changed on copyright application. #6

Open ekitrak opened 6 years ago

ekitrak commented 6 years ago

Applying a copyright changes all line endings to CRLF on Windows. We use LF line endings in our codebase, so after each application I have to go in and change line endings back to LF.

jmini commented 6 years ago

Thank you for reporting this your issue. I will try to have a look at it.

I did not wrote the plugin myself (it is a fork from a project hosted on sourceforge that was no longer available).

Will you by any chance make a contribution for this? If yes I will be happy to review, test and merge it.

From what I know from the eclipse inside, there is a utility method that should be called in order to fix the lines endings (according to the settings) after any modification of a file.

jmini commented 6 years ago

In Eclipse IDE:

The pref key is line.separator in the bundle org.eclipse.core.runtime.

Corresponding Java constant: org.eclipse.core.runtime.Platform.PREF_LINE_SEPARATOR

In the Eclipse-Copyright-Generator plugin, the code handling the copyright modification is located in the com.wdev91.eclipse.copyright.model.CopyrightManager.CopyrightJob class. I guess it should be rewritten to use more features of the Eclipse Framework.