[Feature Request] Add option to hide song title & album cover in Android media player

enduring78 commented 4 months ago

I know this might be a niche feature request, but it would be really great to be able to hide the current song title and media art, and only show the playback position and media controls in the native Android media player.

One reason someone might want this is if the currently playing media art does not fit in the lockscreen. Android used to offer a option to not show media art a few years back, but it was eventually removed.

Another reason is when someone does not want others to see the currently playing song, perhaps in a professional setting.

Chaphasilor commented 4 months ago

Hmm, I think that's too niche of a feature to be honest. It's probably possible to do, but I doubt anyone but you would actually use that.
What's your specific reason for requesting the feature? 🤔

enduring78 commented 4 months ago

Thank you for your reply! I would use this feature primairly for the 2 use cases listed:

I am often in a professional setting, where I am playing music in my car and pause playback when I walk in to the office. When my phone receives a notification or the screen wakes for another reason, everyone sees the music player card. Also, I very often mirror my phone's screen and sometimes forget to dismiss the player and people focus on the media player instead of what I intend to show.
I have minimal background, and the album art does not always match this. This is very much personal though, and not the main reason.

I completely get it if you don't want to implement this, but I at least wanted to bring it up in case it is a simple thing or some other people are also thinking about ;)

Overall, huge fan of your app. I may not fit the 'normal' usec ase, but it is nearly perfect for me.

Chaphasilor commented 4 months ago

How technically versed are you? The change is simple, but as I said, it doesn't qualify as a feature for the app imo.

But what you could do instead is fork the app, create a new branch, and there apply your change. Then you can build your own custom version, and would be able to "easily" get the latest updates of the regular version too.

enduring78 commented 4 months ago

Pretty much none to be honest. I know my way around in Linux systems pretty well, and know a fair bit about how Android is build up, but that's about it.

I am happy to change that though! Do you have any resources on how to start, and where to look for this?

Chaphasilor commented 4 months ago

Sure! Here in the repo, there's a file called "CONTRIBUTING.md", which should have most of the info to get you started. It's also linked in the readme.

Once you have the regular app working, I can point you to the needed changes, or even make the changes for you.

Let me know if you need any help with the setup!

enduring78 commented 4 months ago

Thank you for the instructions! I installed Android Studio and Flutter. I also cloned the 'redesign' branch to a folder.

Running flutter doctor presents me with the output outlined in the Flutter docs, so that seems good. After that, I am a bit stuck. I now have the project in front of me with Android Studio, but when I try to run the emulator just seems to crash:

How would I proceed just building the current version, to check if everything is fine before trying to modify anything?

Chaphasilor commented 4 months ago

Well if you read the error message, it says "not enough disk space". I know that problem very well ^^
That means Flutter + Finamp aren't even trying to start yet.

At this point, instead of using an emulator, I'd suggest simply connecting your phone via USB, enabling USB debugging on it (in the developer settings), and then using your phone to debug the app!
You should find detailed instructions for that online.

To test out if Flutter is working correctly, you can run the command flutter build apk --debug from a terminal within the base/root of the project. That should build the debug APK, without installing/launching it yet.

Chaphasilor commented 4 months ago

Any progress? :)

enduring78 commented 4 months ago

Hey!

Up until now, I have been running this stuff within a VM, as I thought that would be easier since it would not intervene with my existing programs.

However, the USB pass trough seems very buggy, so I migrated everything over to a space laptop today, hope to give another update soon ;)

enduring78 commented 3 months ago

Okay, so I managed to get the app running on a test device. What is the next step to remove the covert art and remove/replace the title shown in the Android quick settings?

Chaphasilor commented 2 months ago

Hey, sorry about not replying earlier!

The needed change is here: https://github.com/jmshrv/finamp/blob/redesign/lib/services/queue_service.dart#L1056-L1059

You'd simply need to comment these out, or replace them with generic strings (since title is required).

enduring78 commented 5 days ago

Hey, sorry for my late reply. I totally missed your message and only saw it when I created a new issue today.

I am happy to say I succeeded removing the artist string with a static one!

Chaphasilor commented 5 days ago

Hey, that's great to hear! Did you also manage to merge in the changes of the 0.9.10 and 0.9.11 updates? If you're struggling with it, I could help you out ^^

jmshrv / finamp

[Feature Request] Add option to hide song title & album cover in Android media player #726