jmsigner / amt

38 stars 13 forks source link

update_vonmises function #29

Closed CBeardsworth closed 4 years ago

CBeardsworth commented 4 years ago

If the costa coefficient is negative then this row: new_conc <- unname(dist$params$kappa + beta_cos_ta) can lead to a negative kappa value, which is (apparently) not allowed. Should this be abs(unname(dist$params$kappa + beta_cos_ta))?

jmsigner commented 4 years ago

Thanks for bringing this up, this not entirely resolved yet. We will give an error/warning in the next update.