jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
900 stars 77 forks source link

Inconsistent hover/active indicator colors #128

Closed francoism90 closed 3 years ago

francoism90 commented 3 years ago

Before submitting

Details

Please add the following information:

Unless this is a non-visual issue, always add screenshots to help describe your problem.

When clicking on the clipboard extension:

image

When clicking on the Espresso extension:

image

Same actions performed on the default shell:

image

image

Not a big issue, thanks for this great theme! :)

jnsh commented 3 years ago

This seems to happen because the espresso extension provides customized panel-button widget, which doesn't provide e.g. :checkedor :active CSS pseudo class when the button is clicked. Therefore it only has the mouse-over :hover class, and is styled based on that.

This isn't apparent with the default shell theme, because they use identical styling for :hover and :active, :checked etc.

I'm fairly certain there's nothing that could be done from the theme's side to this. Either way it would be more appropriate to correct this to the extension itself, instead of applying workarounds to the theme.

Please report this as an issue to the extension.

francoism90 commented 3 years ago

@jnsh Thanks for looking into this and explaining how it works. I'll try to report this to the extension repos instead. :)