search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
900 stars 77 forks source link

gtk3: Fix meson warnings #140

Closed nathan818fr closed 2 years ago

nathan818fr commented 3 years ago
  1. Fix a missing custom_target() dependency (the output_css_dark file is needed to generate gresource, so it must depend on it's custom_target : gtk3_stylesheet_dark)
  2. Use consistent suffix between output_css and related configure_file/custom_target
  3. Fix the file overwritten warning for gtk-dark.css (by using an unique name each time and renaming only for installation).
jnsh commented 2 years ago

@nathan818fr Since you have not responded at all, I'm assuming you have abandoned your PRs here, and I'll be closing them. Let me know if this wasn't the case.

I sincerely hope this wasn't due to my review, as intended to be polite and constructive. Also I was very happy about your ideas for help in https://github.com/jnsh/arc-theme/issues/141 and https://github.com/jnsh/arc-theme/issues/142.