Transparency and tabs broken in GNOME Web 40.1

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)

GNU General Public License v3.0

900 stars 77 forks source link

Transparency and tabs broken in GNOME Web 40.1 #143

Closed ghost closed 2 years ago

ghost commented 3 years ago

Details

Please add the following information:

Distribution and version: Ubuntu 21.04
Versions for the affected applications/desktops/tookits: Gnome Web 40.1, GNOME 3.38.5, meson 0.56.2, inkscape 1.1, sassc n/a, libsass 3.6.4, sass2scss 1.1.1, sass 3.5
Installation method (package or compiled manually): Built from release
Arc-theme version: arc-theme-20210412

Unless this is a non-visual issue, always add screenshots to help describe your problem.

Files and Terminal, wallpaper is visible behind them. Screenshot from 2021-07-02 15-13-34

GNOME Web, headerbar is entirely opaque. Screenshot from 2021-07-02 15-13-56

Tabs completely lack styling and look very out of place. Screenshot from 2021-07-02 15-14-55

jnsh commented 3 years ago

Thank you for the report.

I can reproduce the problems in GNOME Web, and will take a look at fixing them at some point.

Files and Terminal, wallpaper is visible behind them.

Sorry I'm not sure what's the problem here? The transparent terminal background? If so, does GNOME Terminal in ubuntu ship with the option to enable transparent background? Arc-theme certainly should be using a non-transparent background color on gnome-terminal by default.

ghost commented 3 years ago

Thank you for the report.

I can reproduce the problems in GNOME Web, and will take a look at fixing them at some point.

Files and Terminal, wallpaper is visible behind them.

Sorry I'm not sure what's the problem here? The transparent terminal background? If so, does GNOME Terminal in ubuntu ship with the option to enable transparent background? Arc-theme certainly should be using a non-transparent background color on gnome-terminal by default.

There isn't, it's just to show the expected behaviour of the headerbar being transparent.

jnsh commented 3 years ago

I had a quick look at this. The non-transparent headerbar issues derives from libhandy unified window styling, where the headerbar is always drawn on top of the solid window background. You might be able to hack this in epiphany by removing the window background-color, and applying it where necessary (e.g. tab bar), but this could result in transparent background in unexpected spots, so I don't think that would be safe enough to add to the theme by default.

For the tab-bar, it looks like libhandy has added its own tab bar widget, which is now used in epiphany. I'll update the libhandy Arc styling to include that.

jnsh commented 2 years ago

I've added styling for the libhandy tabs in https://github.com/jnsh/arc-theme/commit/6e06012f1e0d241c6c25a80618b6420557552c13, which fixes the epiphany tabs. Sorry about the delay...

Again, the header transparency can't be fixed unfortunately, so I think this issue can be closed now.

Thank you again for reporting this :)