Text contrast

[lnicola]

Hello!

Would it be possible to increase the text contrast It's partly a matter of taste, of course, but text in Adwaita looks much better to me. Look at the labels below:

This was prompted by an inadvertent change in Firefox. Below, the left rendering is a bug, while the right is how it's supposed to look like with Arc. I think the left version looks much better.

Here is Firefox with Adwaita:

[lnicola]

On my system, the darker part of the horizontal bar of the "T" in "Themes" is #5c616c with Arc and #000000 with Adwaita. The darker part of the "l" in "Applications" is #7b7f88 vs. #323232. The background is #f5f6f7. That's objectively pretty poor contrast:

[lnicola]

Stealing two colors from Adwaita seems to "fix" this:

$text_color: if($variant == 'light', black, white);
$fg_color: if($variant == 'light', #2e3436, #eeeeec);

[jnsh]

This has been discussed ad nauseam, and won't be changed. See https://github.com/jnsh/arc-theme/wiki/Common-problems#text-against-light-background-is-too-lightlow-contrast

Changing the $text_color and $fg_color variables for SASS based themes works, but the text won't be changed for the rest of the themes. The above link has a suggested sed command that can be used to change the text color in all source files, and therefore all themes.

[lnicola]

Ah, sorry. I checked the open issues, but not the closed ones.

I can understand your stance on not making significant changes to the theme. I still think it's a desirable change, but it's fair enough if you don't want that.