search

jnsh / arc-theme

A flat theme with transparent elements (actively maintained fork)
GNU General Public License v3.0
900 stars 77 forks source link

Application icons too large with 200% scale #156

Closed dieggsy closed 2 years ago

dieggsy commented 2 years ago

Reposting here since the original repo is unmaintained:

I'm using Gnome 40 on Fedora 34. I have a 2560x1440 screen with 200% scaling set. Below is a comparison at the same scale level (200%) between the default shell theme vs arc shell themes. This weirdly seems to happen the second time I access the applications and every time after, but not the first after switching the theme.

Default: Screenshot from 2021-09-23 15-37-10

Arc: Screenshot from 2021-09-23 15-37-30

jnsh commented 2 years ago

Thank you for the report. Does this happen with all your shell extensions (apart from user-theme) disabled?

dieggsy commented 2 years ago

@jnsh I turned off all other extensions and theming (besides the Arc shell theme) and rebooted just to be sure, and it does still seem to happen.

jnsh commented 2 years ago

Ok, thank you for testing.

I know gnome-shell scales the icons automatically according to available space, so it could be that paddings for the icon grid are just different in Arc. However, it seems odd that the icons seem to be overlapping each other slightly, so this could be something not that obvious as well.

I'll investigate this at some point, but unfortunately at the moment I'm rather busy to get the GTK4 port finalized.

dieggsy commented 2 years ago

@jnsh Right. It's odd that on first entry it doesn't seem to happen. And no worries - please let me know if there's anything else I can do to help, Otherwise, I'm a patient guy (and I don't use the applications view a whole lot). Thanks a lot for your work on the theme!

dieggsy commented 2 years ago

I was testing this and on quickly opening and closing this view over and over, the icons are sometimes too large, sometimes the right size.

Edit: Accidentally closed, sorry.

dieggsy commented 2 years ago

One more thing: this is also wih .80 font scaling in gnome-tweaks, but changing that to 1.0 seemed to have no effect either

jnsh commented 2 years ago

Looks like I was able to reproduce similar issue on my 1920x1080 screen. However the same thing happens with default theme as well. I was able to reproduce this with default theme at 150%, 175% and 200% scaling at several occasions, but it doesn't seem to happen every time.

Therefore this seems like an upstream bug to me. I doubt there could be anything in the Arc theme that could be done to circumvent this.

I opened an issue for this in https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4677

dieggsy commented 2 years ago

Thanks for following up and for opening that issue. Weirdly, I haven't been able to reproduce this in the default theme.

jnsh commented 2 years ago

I had left this open in case I could think of something to this, but without being able to reproduce your exact issue, there's nothing I can do. Looks like the similar issue I described on my previous response doesn't happen in gnome-shell 41 either.

Also seeing there's another upstream bug about oversized grid icons, I'm even more confident that this is caused by something in gnome-shell, rather than something being off with the theme.

@dieggsy If you are still experiencing this issue, I hope it gets sorted somehow. If you're confident editing the theme .scss file, you could try adjusting paddings and other sizing in the grid. If you find something that helps, I may be able to apply it to the theme as a fix.

Closing for now. Feel free to continue discussion, if there's anything.