Closed fossfreedom closed 2 years ago
In both cases, yes... Thank you for spotting, and pointing this out. Looks like I completely forgot about this little detail.
Luckily in this case, this shouldn't be a huge deal. If building for gnome-shell 41 or cinnamon 5.0, the build system simply falls back to latest supported versions (i.e. gnome-shell 40 and cinnamon 4.8). Cinnamon 5.0 theme simply symlinks to 4.6, so there's zero difference for the build result. Changes between gnome-shell 40 and 41 themes are also so minor, that there's practically no difference that users could notice.
However, this still requires a hotfix, and a brown-paper-bag release. I'll sort that out tomorrow.
Thanks again for reporting this :)
I've pushed commits that fix these, but decided that this probably isn't good enough reason for hotfix release after all.
Only situation where this could cause issues, is if the gnome-shell theme is compiled into a gresource and manually applied to be used in gnome-shell, and user is also using switchable e-privacy/lcdshadow feature. This is due to icons from https://github.com/jnsh/arc-theme/commit/1501f526e54399884ed1209fdd19eeeacf79a981 not being present, but IIRC that shouldn't result in crash either (although I could be wrong).
There's likely going to be another release relatively soon, with the fix included.
Closing due to the fix in master
. Thank you again for the report :)
Release 2021-10-18
Quick query - for GNOME Shell 41 and Cinnamon 5 building - does this meson build line need a value "41" to be added to the array?
https://github.com/jnsh/arc-theme/blob/master/common/gnome-shell/meson.build#L2
Similarly for Cinnamon 5 - does 5/5.0 need to be add here?
https://github.com/jnsh/arc-theme/blob/master/common/cinnamon/meson.build#L2