jnsmalm / pixi3d

The 3D renderer for PixiJS. Seamless integration with 2D applications.
https://pixi3d.org
MIT License
752 stars 43 forks source link

update to maths utilities #128

Closed GordonTombola closed 1 year ago

GordonTombola commented 1 year ago

quaternion

vector

quaternion to euler was extremely unreliable in test cases, seems unfitting to provide it as a utility function when it doesn't give exactly what the user would expect

jnsmalm commented 1 year ago

Thanks! Would it be possible for you to create some tests for quaternion toEuler function?

GordonTombola commented 1 year ago

Thanks! Would it be possible for you to create some tests for quaternion toEuler function?

sure, I'll take a look into it when I get the chance

GordonTombola commented 1 year ago

Thanks! Would it be possible for you to create some tests for quaternion toEuler function?

Just looking into sorting a test out, struggling to understand how to extract an image from the canvas, not entirely sure the best way to do this? I've looked at using the extract plugin on the renderer but that doesn't appear to work for me

GordonTombola commented 1 year ago

After some tinkering, I think its best not to implement as the test cases weren't reliable across more than 2 axis of rotation and beyond 90 degrees +/- in any axis

jnsmalm commented 1 year ago

I see, thanks for giving it a go :)