Closed GordonTombola closed 1 year ago
Nice, I'll take a look soon!
Sorry for the delay, have been busy. Everything looks good but could you please change to have same formatting as before with number of spaces etc?
Sorry for the delay, have been busy. Everything looks good but could you please change to have same formatting as before with number of spaces etc?
sure, I'll get it sorted soon
Sorry for the delay, have been busy. Everything looks good but could you please change to have same formatting as before with number of spaces etc?
found the culprit, webgl glsl editor extension in vscode, more harm than good
formatting should be in line with previous standards
Thank you for this!
After merging this everything was completely broken (couldn't even start). I dropped that commit, maybe something happened after your format changes?
After merging this everything was completely broken (couldn't even start). I dropped that commit, maybe something happened after your format changes?
Odd, I'll look into this
Shadows for instances can be rendered in a single pass, cutting calls drastically if you had to use a new mesh3d for every mesh you wanted shadows on.
Issue I see with this: skinning and texture shader that extend the shadow shader won't include instancing. I don't see this as a major problem as skinned meshes and animations in general don't apply to instances (I'm interested to see what can be done about animations on instances)