search

joalla / discogs_client

Continuation of the "Official Python Client for the Discogs API"
https://python3-discogs-client.readthedocs.io
Other
310 stars 50 forks source link

discogs_client.tests.test_utils.UtilsTestCase.test_sort fails on Python 3.13 #156

Open wRAR opened 1 month ago

wRAR commented 1 month ago 
FAIL: test_sort (discogs_client.tests.test_utils.UtilsTestCase.test_sort)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "discogs_client/discogs_client/tests/test_utils.py", line 76, in test_sort
    self.assertEqual(utils.Sort.By.ARTIST, 'artist')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: <By.ARTIST: 'artist'> != 'artist'

Found in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1082206 and I can confirm it locally.

JOJ0 commented 1 month ago

@wRAR this is a very old version of python3-discogs-client and I'm wondering how the official way to remove a package from the Debian archives would be? We don't want to maintain the Debian package anymore. Can you help us with that matter?

wRAR commented 1 month ago

@JOJ0 the official way to remove a package from Debian unstable/testing is making sure there are no reverse dependencies (there are currently two direct ones) and then filing an RM bug.

JOJ0 commented 3 weeks ago

@wRAR thanks a lot, sorry for late reply, I should finally get to removing it. One dependency is github.com/joj0/discodos.git, not sure about the second yet.

wRAR commented 3 weeks ago

beets uses python3-discogs-client for build-time tests and autopkgtests.

JOJ0 commented 2 weeks ago

@wRAR Hi sgain I'm so sorry that I'm so bad at this and slow to respond/act.

I justrealized that python-discogs-client is somewhat maintained in Debian. Who is the maintainer? I see v2.5, which is notterribly old but most importantly I think we recently fixedsom Pytjon 12 related things which might address the issue: https://github.com/joalla/discogs_client/pull/141/files

What I could do to help js push out a pypi release by the end of this week

wRAR commented 2 weeks ago

I justrealized that python-discogs-client is somewhat maintained in Debian.

I can't say so. If you no longer want to be listed as its maintainer it must be formally orphaned as there are no other human maintainers listed.

I see v2.5

It was uploaded 2 years ago as a team upload.

JOJ0 commented 2 weeks ago

Ok, hi again @wRAR thanks again for the patience. I now did the following:

After thinking this through again I believe that the package is essential to stay in Debian since https://packages.debian.org/source/trixie/beets depends on it and I can imagine that having beets available out-of-the box on Debian is worth it.

Thanks for pointing me in the right direction @wRAR, is there anything else I can do?

wRAR commented 2 weeks ago

is there anything else I can do?

No, though I suggest considering doing the same for other your packages you don't want to maintain. Thanks.

JOJ0 commented 2 weeks ago

is there anything else I can do?

No, though I suggest considering doing the same for other your packages you don't want to maintain. Thanks.

Yes. Thanks. A little off-topic in this repo but I don't care and I think it's not a big deal for my fellow repo owners if I continue to talk about "other" Debian packages within this issue :-)

I just filed removal requests for the remaining two packages I'm listed as a maintainer. I was not 100% sure if filing against releases.debian.org was correct (since they are in testing already). My goal is to remove them from Debian entirely.

wRAR commented 2 weeks ago

The correct way to remove a package from Debian is to file a removal from sid against ftp.debian.org. https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#removing-packages